[PATCH] D62371: [llvm-symbolizer] Flush output on bad input

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 07:20:08 PDT 2019


jhenderson added a comment.

In D62371#1515765 <https://reviews.llvm.org/D62371#1515765>, @jhenderson wrote:

> In D62371#1515682 <https://reviews.llvm.org/D62371#1515682>, @ikudrin wrote:
>
> > I am a bit worried about the test which may, potentially, hang. Don't you think there should be any kind of a watchdog?
>
>
> Fair point, given that without the fix it does hang. Does lit have a built-in timeout option? Otherwise, I think the easiest thing to do is add a timeout to the test script or similar.


I found lit does have a per-test timeout option, but it cannot be configured on an individual test level, only on a whole directory level, which I wasn't keen to do, so I've done a similar thing to what lit does in my test script.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62371/new/

https://reviews.llvm.org/D62371





More information about the llvm-commits mailing list