[PATCH] D59918: [Attributor] Pass infrastructure and fixpoint framework

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D59918#1513855 <https://reviews.llvm.org/D59918#1513855>, @fhahn wrote:

> As additional verification, we could run the attributor again, after materializing the changes from the initial run and check if no new facts are discovered, if the iteration limit is not exceeded. We have something similar in NewGVN and it has been helpful to surface missing links in the virtual representation/ non-determinism (links between the abstract attributes in the Attributor case for example).


I like this idea very much. I'll implement it (as a EXPENSIVE_CHECK) a verify method. Though, I can only check if no new facts were materialized because virtual facts might be rediscovered.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59918/new/

https://reviews.llvm.org/D59918