[PATCH] D62345: [MachineScheduler] checkResourceLimit boundary condition update

[Javed Absar via Phabricator via llvm-commits]

javed.absar added a comment.

Would this end up prioritising 'resourcelimited' too much? Looks like there can be performance differences between before and after this change - any  numbers / thoughts on that?



================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1841
+/// If we are checking after scheduling a node, we should return true when
+/// the equations are equal.
 static bool checkResourceLimit(unsigned LFactor, unsigned Count,
----------------
maybe reword 'equations are equal' to something more contextual ....


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1845
+  if (AfterSchedNode)
+    return (int)(Count - (Latency * LFactor)) >= (int)LFactor;
+  else
----------------
repeated computation


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62345/new/

https://reviews.llvm.org/D62345