[PATCH] D62319: IR: add 'byval(<ty>)' variant to 'byval' function parameters

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp:1207-1211
+      unsigned FrameSize;
+        if (Arg.ByValType)
+          FrameSize = DL.getTypeAllocSize(Arg.ByValType);
+        else
+          FrameSize = DL.getTypeAllocSize(ElementTy);
----------------
Ternary operator


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:9076-9080
+        unsigned FrameSize;
+        if (Args[i].ByValType)
+          FrameSize = DL.getTypeAllocSize(Args[i].ByValType);
+        else
+          FrameSize = DL.getTypeAllocSize(ElementTy);
----------------
Ternary operator


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:9583-9587
+        unsigned FrameSize;
+        if (Arg.getParamByValType())
+          FrameSize = DL.getTypeAllocSize(Arg.getParamByValType());
+        else
+          FrameSize = DL.getTypeAllocSize(ElementTy);
----------------
Ternary operator


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62319/new/

https://reviews.llvm.org/D62319