[PATCH] D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 24 02:49:57 PDT 2019
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Looks good, apart from one small question. I'm away after the end of the day, so you'll need to get someone else to land this for you. Alternatively, request commit access as documented here: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
FYI, you can also mark patches as requiring committing before or after other patches by using the "edit related objects" button.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:381
+ WithColor::warning(errs(), ToolName) << Message << "\n";
+ errs().flush();
+}
----------------
Why are you flushing here?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62275/new/
https://reviews.llvm.org/D62275
More information about the llvm-commits
mailing list