[PATCH] D62349: Change ELF tools to allow multiple dynsym, versym, verdef and verneed sections per file.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1429-1430
     case ELF::SHT_LLVM_CALL_GRAPH_PROFILE:
       if (DotCGProfileSec != nullptr)
         reportError("Multiple .llvm.call-graph-profile");
       DotCGProfileSec = &Sec;
----------------
MaskRay wrote:
> jhenderson wrote:
> > Ditto.
> See D62350. Only dynamic sections are duplicated for partitions.
> 
> Static symbol table, etc, are still singleton.
The principle is more general though. For most of these tools, there's no reason why there can't be multiple sections of these other types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62349/new/

https://reviews.llvm.org/D62349