[PATCH] D62326: [ARM] Select a number of fp16 rounding functions

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 00:39:00 PDT 2019


SjoerdMeijer added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/fp16-full.ll:491
 
-; FIXME
-;define void @test_floor(half* %p) {
-;  %a = load half, half* %p, align 2
-;  %r = call half @llvm.floor.f16(half %a)
-;  store half %r, half* %p
-;  ret void
-;}
+define void @test_floor(half* %p) {
+; CHECK-LABEL: test_floor:
----------------
There's a TODO in `fp16-instructions.ll` for these instructions. Either move the test there, or remove the TODOs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62326/new/

https://reviews.llvm.org/D62326





More information about the llvm-commits mailing list