[PATCH] D62338: [globalisel][legalizer] Combine G_TRUNC+G_MERGE_VALUES in artifact combiner
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 23 19:22:51 PDT 2019
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM with nit
================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerArtifactCombinerTest.cpp:87
+ EXPECT_TRUE(ArtCombiner.tryCombineInstruction(*MI1, DeadInstructions, ObserverWrapper));
+ EXPECT_TRUE(DeadInstructions.size() == 0);
+ for (auto *DeadMI : DeadInstructions) {
----------------
EXPECT_EQ(0, .size())
================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerArtifactCombinerTest.cpp:126
+ EXPECT_TRUE(ArtCombiner.tryCombineInstruction(*MI1, DeadInstructions, ObserverWrapper));
+ EXPECT_TRUE(DeadInstructions.size() == 0);
+ for (auto *DeadMI : DeadInstructions) {
----------------
EXPECT_EQ(0, .size())
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62338/new/
https://reviews.llvm.org/D62338
More information about the llvm-commits
mailing list