[PATCH] D62359: [dwarfdump] Make recursion affect the parent chain

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 19:20:17 PDT 2019


dblaikie added a comment.

Is this the desired behavior?

Currently, I assume, searching for a particular DIE offset dumps that DIE, its parent, and all its children. (& the recursion limit is entirely ignored?)

This patch, if I understand it, dumps from the CU to the target DIE until the recursion limit is reached. So you get some parent DIE of the one you searched for.

I would've probably thought that the entire parent chain would be dumped, and then the recursion limit would limit how deep into the children of the target DIE would be dumped.

Thoughts?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62359/new/

https://reviews.llvm.org/D62359





More information about the llvm-commits mailing list