[PATCH] D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with additional small changes (including the changes requested by @daltenty).



================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:110
+
+  if (SymEntPtr->StorageClass & 0x80)
+    StringRef("Unimplemented Debug Name"); 
----------------
Add a comment:
```
// A storage class value with the high-order bit on indicates that the name is a
// symbolic debugger stabstring.
```


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:111
+  if (SymEntPtr->StorageClass & 0x80)
+    StringRef("Unimplemented Debug Name"); 
+  uint32_t Offset = SymEntPtr->NameInStrTbl.Offset;
----------------
Missing "`return`".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61532/new/

https://reviews.llvm.org/D61532