[PATCH] D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 11:04:46 PDT 2019


hintonda marked an inline comment as done.
hintonda added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:312
   inline unsigned getMiscFlags() const { return Misc; }
+  inline bool isFullyInitialized() const { return FullyInitialized; }
   inline unsigned getPosition() const { return Position; }
----------------
serge-sans-paille wrote:
> Why do you need to make that getter public?
I think at some point I needed access, but as of now, FullyInitialized is only used within Option, so it can go away.

Thanks for catching that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62105/new/

https://reviews.llvm.org/D62105





More information about the llvm-commits mailing list