[PATCH] D62331: Break false dependencies on target libraries

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 11:04:46 PDT 2019


dsanders created this revision.
dsanders added a reviewer: bogner.
Herald added subscribers: rupprecht, dexonsmith, steven_wu, mgorny, mehdi_amini.
Herald added a reviewer: JDevlieghere.
Herald added a project: LLVM.

For the most part this consists of replacing ${LLVM_TARGETS_TO_BUILD} with
some combination of AllTargets* so that they depend on specific components
of a target backend rather than all of it. The overall effect of this is
that, for example, tools like opt no longer falsely depend on the
disassembler, while tools like llvm-ar no longer depend on the code
generator.

There's a couple quirks to point out here:

- AllTargetsCodeGens is a bit more prevalent than expected. Tools like dsymutil seem to need it which I was surprised by.
- llvm-xray linked to all the backends but doesn't seem to need any of them. It builds and passes the tests so that seems to be correct.
- I left gold out as it's not build when binutils is not available so I'm unable to test it


Repository:
  rL LLVM

https://reviews.llvm.org/D62331

Files:
  cmake/modules/LLVM-Config.cmake
  tools/bugpoint/CMakeLists.txt
  tools/dsymutil/CMakeLists.txt
  tools/llc/CMakeLists.txt
  tools/llvm-ar/CMakeLists.txt
  tools/llvm-c-test/CMakeLists.txt
  tools/llvm-cxxdump/CMakeLists.txt
  tools/llvm-dwp/CMakeLists.txt
  tools/llvm-lto/CMakeLists.txt
  tools/llvm-lto2/CMakeLists.txt
  tools/llvm-rtdyld/CMakeLists.txt
  tools/llvm-xray/CMakeLists.txt
  tools/lto/CMakeLists.txt
  tools/opt/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62331.201018.patch
Type: text/x-patch
Size: 5110 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190523/4c40a427/attachment.bin>


More information about the llvm-commits mailing list