[PATCH] D61935: Fixes PPC64 Tbegin disassembling

[Jinsong Ji via Phabricator via llvm-commits]

jsji added a comment.

BTW: You should create the patch with "full diff" when submitting to Phabricator. See https://llvm.org/docs/Phabricator.html



================
Comment at: lib/Target/PowerPC/PPCInstrHTM.td:30
+let Defs = [CR0] in
 def TBEGIN : XForm_htm0 <31, 654,
+                         (outs), (ins u1imm:$R), "tbegin. $R", IIC_SprMTSPR, []>;
----------------
catenacyber wrote:
> jsji wrote:
> > TBEGIN is NOT the only HTM instructions that has this problem. We should fix all of them together, not just for `TBEGIN` here. Thanks.
> I agree.
> Do you know the complete list ?
> I only know the ones that the capstone fuzzer found so far like tabortdc
You should be able to  identify them easily in this td files: any one that try to access variable that is not defined in asm string should be fixed. 



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61935/new/

https://reviews.llvm.org/D61935