[PATCH] D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: test/DebugInfo/X86/fission-ranges.ll:14
+; MIR-CHECK: DBG_VALUE $rsp, 0, ![[BDIVAR]], !DIExpression(DW_OP_constu, 32, DW_OP_minus)
+; MIR-CHECK: bb.6
+; MIR-CHECK: DBG_VALUE $rsp, 0, ![[BDIVAR]], !DIExpression(DW_OP_constu, 32, DW_OP_minus)
----------------
dstenb wrote:
> Perhaps it does not make a difference in this case, but I think it in general is preferred to use `CHECK-LABEL` directives for block label checks.
The `LABEL` suffix is widely misunderstood to mean "this is a label."
It would be better to match a longer string such as `bb.6:` to ensure it matches the label definition rather than a reference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62196/new/

https://reviews.llvm.org/D62196