[PATCH] D55056: [CMake] Default options for faster executables on MSVC

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added inline comments.


================
Comment at: cmake/modules/ChooseMSVCCRT.cmake:72
+        if ((NOT ${build} STREQUAL "DEBUG") AND (LLVM_TOOL_CLANG_BUILD OR LLVM_TOOL_LLD_BUILD))
+          message(WARNING "Disabling /MT required by LLDB. This will impact runtime performance for Clang or LLD. Preferably build them separately.")
+        endif()
----------------
As far as I understand, /MT is being disabled because it is required by LLDB that it be disabled. Is that correct? If that's the case, I think the message needs to change to be clearer. For example: "Disabling /MT *as* required by LLDB". Right now it reads like /MT is being disabled but it is required by LLDB.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55056/new/

https://reviews.llvm.org/D55056