[PATCH] D62324: [ARM] Select fp16 fabs

[Dave Green via Phabricator via llvm-commits]

dmgreen created this revision.
dmgreen added reviewers: SjoerdMeijer, dnsampaio, miyuki, t.p.northover, ostannard.
Herald added subscribers: hiraditya, kristof.beyls, javed.absar.
Herald added a project: LLVM.

Adds a pattern for the intrinsic, the same as float and double.


https://reviews.llvm.org/D62324

Files:
  llvm/lib/Target/ARM/ARMInstrVFP.td
  llvm/test/CodeGen/ARM/fp16-full.ll


Index: llvm/test/CodeGen/ARM/fp16-full.ll
===================================================================
--- llvm/test/CodeGen/ARM/fp16-full.ll
+++ llvm/test/CodeGen/ARM/fp16-full.ll
@@ -312,13 +312,17 @@
 ;  ret void
 ;}
 
-; FIXME
-;define void @test_fabs(half* %p) {
-;  %a = load half, half* %p, align 2
-;  %r = call half @llvm.fabs.f16(half %a)
-;  store half %r, half* %p
-;  ret void
-;}
+define void @test_fabs(half* %p) {
+; CHECK-LABEL: test_fabs:
+; CHECK:         vldr.16 s0, [r0]
+; CHECK-NEXT:    vabs.f16 s0, s0
+; CHECK-NEXT:    vstr.16 s0, [r0]
+; CHECK-NEXT:    bx lr
+  %a = load half, half* %p, align 2
+  %r = call half @llvm.fabs.f16(half %a)
+  store half %r, half* %p
+  ret void
+}
 
 define void @test_minnum(half* %p, half* %q) {
 ; CHECK-LABEL: test_minnum:
Index: llvm/lib/Target/ARM/ARMInstrVFP.td
===================================================================
--- llvm/lib/Target/ARM/ARMInstrVFP.td
+++ llvm/lib/Target/ARM/ARMInstrVFP.td
@@ -595,9 +595,9 @@
 }
 
 def VABSH  : AHuI<0b11101, 0b11, 0b0000, 0b11, 0,
-                   (outs SPR:$Sd), (ins SPR:$Sm),
+                   (outs HPR:$Sd), (ins HPR:$Sm),
                    IIC_fpUNA16, "vabs", ".f16\t$Sd, $Sm",
-                   []>;
+                   [(set HPR:$Sd, (fabs (f16 HPR:$Sm)))]>;
 
 let Defs = [FPSCR_NZCV] in {
 def VCMPEZD : ADuI<0b11101, 0b11, 0b0101, 0b11, 0,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62324.200986.patch
Type: text/x-patch
Size: 1386 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190523/3299928a/attachment.bin>