[PATCH] D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:712
   VarLocSet &VLS = OutLocs[CurMBB];
   Changed = VLS |= OpenRanges.getVarLocs();
+  // New OutLocs set may be different due to spill, restore or register
----------------
Can this be `VLS | OpenRanges.getVarLocs();` now?


================
Comment at: test/DebugInfo/X86/fission-ranges.ll:14
+; MIR-CHECK: DBG_VALUE $rsp, 0, ![[BDIVAR]], !DIExpression(DW_OP_constu, 32, DW_OP_minus)
+; MIR-CHECK: bb.6
+; MIR-CHECK: DBG_VALUE $rsp, 0, ![[BDIVAR]], !DIExpression(DW_OP_constu, 32, DW_OP_minus)
----------------
Perhaps it does not make a difference in this case, but I think it in general is preferred to use `CHECK-LABEL` directives for block label checks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62196/new/

https://reviews.llvm.org/D62196