[PATCH] D60386: FileCheck [6/12]: Introduce numeric variable definition

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:355
 public:
   explicit FileCheckPattern(Check::FileCheckType Ty,
+                            FileCheckPatternContext *Context, unsigned Line)
----------------
jhenderson wrote:
> probinson wrote:
> > Multiple parameters means you don't need 'explicit'.
> There's still an explicit here (but it's worth noting that `explicit` does still have an effect on multi-parameter constructor).
Really? What effect does `explicit` have on a multi-parameter constructor? My reading of the cppreference.org description is that it used to apply to `T var = {args};` but that is list-initialization starting with C++11.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60386/new/

https://reviews.llvm.org/D60386