[PATCH] D61996: [llvm-objdump][test] Improve testing of some switches #2

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 06:09:36 PDT 2019


jhenderson added a comment.

In D61996#1512299 <https://reviews.llvm.org/D61996#1512299>, @MaskRay wrote:

> I just wanted to ask if you want to make the test easier to read (making the function body empty), or to make it realistic (no change). I'm happy with either choice.


I started looking at simplifying the test input, but quickly realised that I'm not familiar enough with the format, and couldn't get it to work easily. As there isn't a desperate need to change things, I'm inclined to leave it as is, although if others want to make that change, I'm not opposed to it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61996/new/

https://reviews.llvm.org/D61996





More information about the llvm-commits mailing list