[PATCH] D62255: [llvm-objdump][test] Improve testing of some switches #3

Thu May 23 04:24:22 PDT 2019

jhenderson marked 4 inline comments as done.
jhenderson added inline comments.

================
Comment at: test/tools/llvm-objdump/X86/disasm-specific-funcs-mangled-name.test:13
+# CHECK-NEXT:  0000000000000000 _Z3foov:
+# CHECK-NEXT:        0: 90                            nop
+
----------------
grimar wrote:
> jhenderson wrote:
> > grimar wrote:
> > > I would suggest to reduce amount of spaces here and below.
> > > Looks a bit better when compact:
> > > `0: 90 nop`
> > > 
> > > Up to you though.
> > How about I get rid of the 90 and nop completely? I don't think they're needed for the test.
> I though about removing the `Content: '90'`, yes, but was not sure if that works.
I think the only bit that is important is showing the symbol label. After that, we're just testing that disassembly in general works, which is independent of the switch behaviour, I think.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62255/new/

https://reviews.llvm.org/D62255