[PATCH] D62278: [obj2yaml] Support dumping program headers.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I agree with @labath, I don't think this approach is quite right. We should avoid using the strict Offset field if we can, in the obj2yaml output, and we should definitely link them with their sections (i.e. via the Sections: member of a program header). Perhaps we need to update the whole paradigm, to allow for arbitrary data in the list of "Sections"? Something like:

  Sections:
    - Data: '12345678'
    - Section: .text
    - Data: 'abcdef90'
    - Section: .another.text

And I'd probably rename "Sections" to "Members" or similar.

I've been using the FileSize and Offset fields up to now because there isn't a sensible alternative for arbitrary data in program headers not covered by a section, and something like this would make the tests I've written more robust. It would also allow a cleaner obj2yaml output, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62278/new/

https://reviews.llvm.org/D62278