[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

[Penzin, Petr via llvm-commits]

It does not like some part of that instantiation, I am not sure which one yet. Let’s see what I can do about it.

-Petr

From: Yitzhak Mandelbaum [mailto:yitzhakm at google.com]
Sent: Wednesday, May 22, 2019 1:37 PM
To: reviews+D61774+public+f458bb6144ae8e78 at reviews.llvm.org
Cc: Ilya Biryukov <ibiryukov at google.com>; Penzin, Petr <petr.penzin at intel.com>; llvm-commits at lists.llvm.org; Michał Górny <mgorny at gentoo.org>; cfe-commits <cfe-commits at lists.llvm.org>; Theko Lekena <mlekena at skidmore.edu>; Nicolas Lesser <blitzrakete at gmail.com>; Han Shen <shenhan at google.com>
Subject: Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

I'm confused by the error given that getStatementsRange is a function name.  I don't have Visual Studio -- can you find a fix and send a patch? I wonder if taking the address explicitly is enough?  Or, if you know how to trigger this error in clang or gcc, I can fix it myself.

On Wed, May 22, 2019 at 4:31 PM Petr Penzin via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
penzn added inline comments.


================
Comment at: cfe/trunk/lib/Tooling/Refactoring/RangeSelector.cpp:229
+RangeSelector tooling::statements(StringRef ID) {
+  return RelativeSelector<CompoundStmt, getStatementsRange>(ID);
+}
----------------
Sorry for posting here, haven't gotten my bugzilla access yet (requested though).

This breaks with Visual Studio 2017 (15.7.6):

RangeSelector.cpp(229): error C2971: '`anonymous-namespace'::RelativeSelector': template parameter 'Func': 'getStatementsRange': a variable with non-static storage duration cannot be used as a non-type argument


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61774/new/

https://reviews.llvm.org/D61774


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190522/b0472ead/attachment-0001.html>