[PATCH] D62188: Speed up --start-lib and --end-lib.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 02:03:36 PDT 2019


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

For one program, I measured 3.0% time decrease with 0.25% memory increase. Looks great!



================
Comment at: lld/ELF/InputFiles.cpp:1530
+    for (size_t I = FirstGlobal, End = ESyms.size(); I != End; ++I) {
+      if (ESyms[I].st_shndx == SHN_UNDEF)
+        continue;
----------------
Nit:

```
      if (ESyms[I].st_shndx != SHN_UNDEF)
        this->Symbols[I] = Symtab->insert(CHECK(ESyms[I].getName(Strtab), this));
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62188/new/

https://reviews.llvm.org/D62188





More information about the llvm-commits mailing list