[PATCH] D62256: [llvm-readobj] Implement GNU-style output for dynamic table

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 01:56:56 PDT 2019


jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3334
+  Elf_Dyn_Range Table =
+      rectifyDynamicTable<ELFT>(this->dumper()->dynamic_table());
+  if (Table.empty())
----------------
Are there any cases where we don't want the dumper to provide a rectified table? I don't think so. In that case, could the rectify code move into the dynamic_table() method?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62256/new/

https://reviews.llvm.org/D62256





More information about the llvm-commits mailing list