[PATCH] D55305: [RISCV] Add lowering of global TLS addresses

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:523
+                                               SelectionDAG &DAG,
+                                               bool UseGOT) const {
+  SDLoc DL(N);
----------------
I'm curious, is there a reason to have this unused parameter here? (other than symmetry with `getStaticTLSAddr`, that is). 

Removing it could allow you to combine the two cases in `lowerGlobalTLSAddress`. That could make more obvious that in RISC-V we use the same sequence in both cases.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55305/new/

https://reviews.llvm.org/D55305