[PATCH] D62277: [llvm-objdump] Emit error if start address equal to stop address

[Anusha Basana via Phabricator via llvm-commits]

anushabasana created this revision.
anushabasana added reviewers: smeenai, jhenderson.
Herald added subscribers: llvm-commits, rupprecht.
Herald added a project: LLVM.

Fixes PR41862


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62277

Files:
  llvm/test/tools/llvm-objdump/X86/start-stop-address.test
  llvm/tools/llvm-objdump/llvm-objdump.cpp


Index: llvm/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -1403,7 +1403,7 @@
 }
 
 static void disassembleObject(const ObjectFile *Obj, bool InlineRelocs) {
-  if (StartAddress > StopAddress)
+  if (StartAddress >= StopAddress)
     error("Start address should be less than stop address");
 
   const Target *TheTarget = getTarget(Obj);
Index: llvm/test/tools/llvm-objdump/X86/start-stop-address.test
===================================================================
--- llvm/test/tools/llvm-objdump/X86/start-stop-address.test
+++ llvm/test/tools/llvm-objdump/X86/start-stop-address.test
@@ -31,3 +31,5 @@
 // CROSSDATA-DAG:      somedata:
 // CROSSDATA-NEXT:     45:	 74 65                           te
 
+// RUN: not llvm-objdump -d %t.out --start-address=0x18 --stop-address=0x18 2>&1 | FileCheck %s --check-prefix ERR
+// ERR: Start address should be less than stop address


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62277.200847.patch
Type: text/x-patch
Size: 1032 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190523/3b498cec/attachment.bin>