[PATCH] D62241: [FileCheck] Introduce substitution subclasses

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Apart from missing 'override' keywords it looks pretty straightforward. LGTM.



================
Comment at: llvm/include/llvm/Support/FileCheck.h:157
+  /// when defined, or None if the variable is undefined.
+  llvm::Optional<std::string> getResult() const;
+
----------------
This is virtual so should be marked 'override'.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:161
+  /// undefined, or an empty string otherwise.
+  StringRef getUndefVarName() const;
+};
----------------
'override'


================
Comment at: llvm/include/llvm/Support/FileCheck.h:177
+  /// expression in this substitution, or None if evaluation failed.
   llvm::Optional<std::string> getResult() const;
 
----------------
override


================
Comment at: llvm/include/llvm/Support/FileCheck.h:181
+  /// undefined, or an empty string otherwise.
   StringRef getUndefVarName() const;
 };
----------------
override


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62241/new/

https://reviews.llvm.org/D62241