[PATCH] D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 22 11:58:08 PDT 2019
arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: lib/CodeGen/RegAllocFast.cpp:295
+/// Returns false if \p VirtReg is known to not be live into the current block.
+bool RegAllocFast::mayLiveIn(unsigned VirtReg) {
+ if (MayLiveAcrossBlocks.test(TargetRegisterInfo::virtReg2Index(VirtReg)))
----------------
brooksmoses wrote:
> Are you expecting future uses of this to want to use the return value? Looks like it's currently unused, and removing it would simplify some things.
Possibly? The set of rewrite patches inverts the spill logic to restore on use, so these may swap but I haven't tried to rebase it yet
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62249/new/
https://reviews.llvm.org/D62249
More information about the llvm-commits
mailing list