[PATCH] D62179: [llvm-readelf] - Allow dumping of the .dynamic section even if there is no PT_DYNAMIC header.
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 22 10:47:46 PDT 2019
rupprecht accepted this revision.
rupprecht added a comment.
In D62179#1510386 <https://reviews.llvm.org/D62179#1510386>, @jhenderson wrote:
> This is an odd situation anyway (unless you know of a concrete example), so I don't think any users are likely to hit it either way. I don't think we need to follow GNU's behaviour here as a result. We should just do what makes the most sense (and GNU's behaviour doesn't make much sense to me). It would be worth getting somebody else's opinion on this too.
Same here... this patch seems fine, someone would need a use case for:
- Having dynamic sections
- Not having PT_HEADERs
- Needing llvm-readelf to be quiet about it
Which seems unlikely, but maybe wait a day or two.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62179/new/
https://reviews.llvm.org/D62179
More information about the llvm-commits
mailing list