[PATCH] D61887: [SelectionDAG] computeKnownBits - support constant pool values from target

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2892
+      Type *CstTy = Cst->getType();
+      if ((NumElts * BitWidth) == CstTy->getPrimitiveSizeInBits()) {
+        // If its a vector splat, then we can (quickly) reuse the scalar path.
----------------
Would it be safer to check the extension type here too? Is it possible for the constant itself to be wider than the memory VT, but equal to the width of an extension such that this check would let it through?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61887/new/

https://reviews.llvm.org/D61887