[PATCH] D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

This looks good to me (I'll leave it for more comments).



================
Comment at: lib/CodeGen/LiveDebugValues.cpp:436
+
+    // Close previous variable's location range.
+    DebugVariable V(DMI->getDebugVariable(),
----------------
NikolaPrica wrote:
> aprantl wrote:
> >  previous variable's -> this variable's previous
> > 
> > Does this do the right thing for two fragments of the same variable where one of them has a longer live range than the other? Or is this a non-issue here?
> I think it does the right thing. It does the same thing as `transferDebugValue`. Variable's locations are related to pair of DILocalVariable and DILocation thus this closes DILocalVariable location with matching DILocation.
NB: as it stands, I don't believe LiveDebugValues handles fragments at all, which I've written up in https://bugs.llvm.org/show_bug.cgi?id=41979

(Thus this patch neither helps nor harms fragment handling).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62196/new/

https://reviews.llvm.org/D62196