[PATCH] D62130: [AArch64][SVE2] Asm: add saturating add/sub instructions

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 22 07:59:25 PDT 2019


chill added inline comments.


================
Comment at: test/MC/AArch64/SVE2/sqadd.s:12
+// CHECK-INST: sqadd z0.b, p0/m, z0.b, z1.b
+// CHECK-ENCODING: [0x20,0x80,0x18,0x44]
+// CHECK-ERROR: instruction requires: sve2
----------------
The encoding does not look right.

In  https://reviews.llvm.org/D62000 there's this bit:

```class sve2_int_arith_pred<bits<2> sz, bits<6> opc, string asm,
                          ZPRRegOp zprty>
...
  let Inst{21-20} = 0b01;
  let Inst{20-16} = opc{5-1};
...
```

which has overlapping bit 20.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62130/new/

https://reviews.llvm.org/D62130





More information about the llvm-commits mailing list