[PATCH] D62146: FileCheck: Improve FileCheck variable terminology

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked 3 inline comments as done.
thopre added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:106
 
 class FileCheckPatternContext;
 
----------------
jhenderson wrote:
> Does FileCheckPatternContext still make sense as a name?
Yes, it refers to a FileCheckPattern which is the part after the colon in a CHECK (or similar) directive. String variables were called pattern variables because patterns only supported one type of variables. Now we have patterns supporting string and numeric variable. The pattern context holds the current live string and numeric variables.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:238
 class FileCheckPatternContext {
   friend class FileCheckPattern;
 
----------------
jhenderson wrote:
> Does FileCheckPattern still make sense in the new naming scheme?
I think so, a pattern refers to what a CHECK directive need to match. In the end it becomes a regular expression pattern that is being matched, whether it includes no variable, string variables, numeric expressions or both.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62146/new/

https://reviews.llvm.org/D62146