[PATCH] D62241: [FileCheck] Introduce substitution subclasses
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 22 03:47:26 PDT 2019
thopre created this revision.
thopre added reviewers: jhenderson, jdenny, probinson, arichardson.
thopre added a project: LLVM.
With now a clear distinction between string and numeric substitutions,
this patch introduces separate classes to represent them with a parent
class implementing the common interface. Diagnostics in
printSubstitutions() are also adapted to not require knowing which
substitution is being looked at since it does not hinder clarity and
makes the implementation simpler.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D62241
Files:
llvm/include/llvm/Support/FileCheck.h
llvm/lib/Support/FileCheck.cpp
llvm/test/FileCheck/numeric-defines.txt
llvm/test/FileCheck/string-defines.txt
llvm/test/FileCheck/verbose.txt
llvm/unittests/Support/FileCheckTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62241.200691.patch
Type: text/x-patch
Size: 17628 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190522/90b6eccb/attachment.bin>
More information about the llvm-commits
mailing list