[PATCH] D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location

[Nikola Prica via Phabricator via llvm-commits]

NikolaPrica marked 2 inline comments as done.
NikolaPrica added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:436
+
+    // Close previous variable's location range.
+    DebugVariable V(DMI->getDebugVariable(),
----------------
aprantl wrote:
>  previous variable's -> this variable's previous
> 
> Does this do the right thing for two fragments of the same variable where one of them has a longer live range than the other? Or is this a non-issue here?
I think it does the right thing. It does the same thing as `transferDebugValue`. Variable's locations are related to pair of DILocalVariable and DILocation thus this closes DILocalVariable location with matching DILocation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62196/new/

https://reviews.llvm.org/D62196