[PATCH] D59649: [ELF] Improve error message for relocations to symbols defined in discarded sections

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 22 01:04:33 PDT 2019


ruiu added a comment.

Overall looking good.

Somewhat unrelated, but maybe we should clear ComdatGroups map once name resolution pass is done? COMDAT signatures are long strings, and discarding them from memory might save nontrivial amount of memory.



================
Comment at: ELF/InputFiles.cpp:117
-  // is used to uniquify them.
-  static llvm::DenseSet<llvm::CachedHashStringRef> ComdatGroups;
-
----------------
Why did you move this to Symtab?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59649/new/

https://reviews.llvm.org/D59649





More information about the llvm-commits mailing list