[PATCH] D61117: Fix Bug 41353 - unique symbols printed as D instead of u

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/X86/unique.test:39
+    Section: .progbits_execinstr
+    Binding: STB_GNU_UNIQUE
+...
----------------
mmpozulp wrote:
> jhenderson wrote:
> > Could you add a unique symbol without a section to show it gets 'u', please?
> Is that the behavior that we want for llvm-nm? If I run GNU nm (version 2.27-34.base.el7) it reports 'U' instead of 'u' for a unique symbol without a section
> ```
> Symbols:
>   - Name:    nosection
>     Binding: STB_GNU_UNIQUE
> ```
> ```
>                  U nosection
> ```
I can confirm. Symbol is undefined, but unique and GNU nm shows 'U' in this case:

```
Symbol table '.symtab' contains 2 entries:
   Num:    Value          Size Type    Bind   Vis      Ndx Name
     0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
     1: 0000000000000000     0 NOTYPE  UNIQUE DEFAULT  UND foo
```



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61117/new/

https://reviews.llvm.org/D61117