[PATCH] D62188: Speed up --start-lib and --end-lib.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 21:49:19 PDT 2019


ruiu marked an inline comment as done.
ruiu added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:995
+    }
 
     fatal(toString(this) + ": unexpected binding: " + Twine((int)Binding));
----------------
MaskRay wrote:
> Missing `default:`
Does this have to be exhaustive? We have a `fatal` after this switch. Anyways, I think I can rewrite this with `if`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62188/new/

https://reviews.llvm.org/D62188





More information about the llvm-commits mailing list