[PATCH] D62226: [libFuzzer] Ignore synthetic exceptions on Fuchsia

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: dexonsmith.

lgtm with one nit: either change to an assert or improve the comment to clarify what other cases are expected



================
Comment at: compiler-rt/lib/fuzzer/FuzzerUtilFuchsia.cpp:244
+    // Ignore signals and informational synthetic exceptions.
+    if (!ZX_PKT_IS_EXCEPTION(Packet.type) ||
+        ZX_EXCP_THREAD_STARTING == Packet.type ||
----------------
I think !ZX_PKT_IS_EXCEPTION here is unexpected and would indicate a bug.
There should be no packets received except the ones you've asked for.
Probably you should just assert that it is.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62226/new/

https://reviews.llvm.org/D62226