[PATCH] D62210: [WebAssembly] Implement __builtin_return_address for emscripten

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 18:18:59 PDT 2019


tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

If a cross-platform version of this function emerges, we can always update the name here and in emscripten later. I think this is fine to merge now because it is consistent in the context of things that exist today and can easily be extended. I also think it is good to leave this as a compiler error; there's not much of a difference between this and any other runtime function that wasm does not support but that an individual user might want to supply. Maybe a separate PR should make all runtime functions linker errors instead of compile errors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62210/new/

https://reviews.llvm.org/D62210





More information about the llvm-commits mailing list