[PATCH] D62210: [WebAssembly] Implement __builtin_return_address for emscripten

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 17:41:15 PDT 2019


tlively added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/return-address-unknown.ll:2
+; RUN: llc < %s -asm-verbose=false 2>&1 | FileCheck %s
+; XFAIL: *
+
----------------
quantum wrote:
> tlively wrote:
> > I don't think this XFAIL should be necessary any more, right?
> It is necessary. Without the XFAIL it gets count as an unexpected failure.
Oh, because llc is still "failing", even though the test now passes. Try adding a `not` to the run line, like `; RUN: not llc..`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62210/new/

https://reviews.llvm.org/D62210





More information about the llvm-commits mailing list