[compiler-rt] r361313 - [libFuzzer] Reduce flakiness of merge-sigusr.test.

[via llvm-commits]

Hi Matt,

This change is causing the test you re-enabled to fail on our internal linux bot. The test output is not terribly informative though and I am seeing if I can figure out where it is failing, but wanted to give you a heads up.

Douglas Yung

-----Original Message-----
From: llvm-commits <llvm-commits-bounces at lists.llvm.org> On Behalf Of Matt Morehouse via llvm-commits
Sent: Tuesday, May 21, 2019 14:16
To: llvm-commits at lists.llvm.org
Subject: [compiler-rt] r361313 - [libFuzzer] Reduce flakiness of merge-sigusr.test.

Author: morehouse
Date: Tue May 21 14:15:51 2019
New Revision: 361313

URL: http://llvm.org/viewvc/llvm-project?rev=361313&view=rev
Log:
[libFuzzer] Reduce flakiness of merge-sigusr.test.

Double the number of files to merge, and use wait instead of sleep.

Modified:
    compiler-rt/trunk/test/fuzzer/merge-sigusr.test

Modified: compiler-rt/trunk/test/fuzzer/merge-sigusr.test
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/fuzzer/merge-sigusr.test?rev=361313&r1=361312&r2=361313&view=diff
==============================================================================
--- compiler-rt/trunk/test/fuzzer/merge-sigusr.test (original)
+++ compiler-rt/trunk/test/fuzzer/merge-sigusr.test Tue May 21 14:15:51 
+++ 2019
@@ -1,8 +1,7 @@
 # Check that libFuzzer honors SIGUSR1/SIGUSR2  # FIXME: Disabled on Windows for now because of reliance on posix only features  # (eg: export, "&", pkill).
-# TODO(morehouse): rethink test and reenable for linux.
-UNSUPPORTED: darwin, windows, linux
+UNSUPPORTED: darwin, windows
 RUN: rm -rf %t
 RUN: mkdir -p %t
 RUN: %cpp_compiler %S/SleepOneSecondTest.cpp -o %t/LFSIGUSR @@ -15,12 +14,20 @@ RUN: echo d > %t/C2/d
 RUN: echo e > %t/C2/e
 RUN: echo f > %t/C2/f
 RUN: echo g > %t/C2/g
+RUN: echo h > %t/C2/g
+RUN: echo i > %t/C2/g
+RUN: echo j > %t/C2/g
+RUN: echo k > %t/C2/g
+RUN: echo l > %t/C2/g
+RUN: echo m > %t/C2/g
+RUN: echo n > %t/C2/g
+RUN: echo o > %t/C2/g
 
 RUN: %run %t/LFSIGUSR -merge=1 -merge_control_file=%t/MCF %t/C1 %t/C2 2>%t/log & export PID=$!
 RUN: sleep 3
 RUN: pkill -SIGUSR2 -P $PID
 RUN: kill -SIGUSR2 $PID
-RUN: sleep 6
+RUN: wait $PID
 RUN: cat %t/log | FileCheck %s --dump-input=fail
 RUN: grep C2/g %t/MCF
 RUN: grep STARTED %t/MCF


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits