[PATCH] D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS

Tue May 21 15:15:22 PDT 2019

nickdesaulniers abandoned this revision.
nickdesaulniers added a comment.

In D62218#1510979 <https://reviews.llvm.org/D62218#1510979>, @nathanchance wrote:

> Is there a point to adding this if it isn't a user selectable option? LLVM_ENABLE_PLUGINS doesn't have an `option` in any cmake files, it is only ever `set`.

Huh, weird...

  $ cd llvm/build
  $ rm -rf *
  $ cmake .. -DCMAKE_BUILD_TYPE=Release -G Ninja -DLLVM_ENABLE_LLD=ON -DLLVM_ENABLE_PROJECTS="clang;lld" -DLLVM_TARGETS_TO_BUILD="AArch64;ARM;X86" -DLLVM_ENABLE_PLUGINS="ON"
  $ ninja check-llvm-bugpoint
  ...
  [0/1] Running lit suite /android0/llvm-project/llvm/test/BugPoint
  Testing Time: 0.11s
    Unsupported Tests  : 10

  $ cmake .. -DCMAKE_BUILD_TYPE=Release -G Ninja -DCMAKE_C_COMPILER=/android1/android-master/prebuilts/clang/host/linux-x86/clang-r353983c/bin/clang -DCMAKE_CXX_COMPILER=/android1/android-master/prebuilts/clang/host/linux-x86/clang-r353983c/bin/clang++ -DLLVM_ENABLE_LLD=ON -DLLVM_ENABLE_PROJECTS="clang;lld" -DLLVM_TARGETS_TO_BUILD="AArch64;ARM;X86" -DLLVM_BUILD_LLVM_DYLIB="ON"
  $ ninja check-llvm-bugpoint
  [12/13] Running lit suite /android0/llvm-project/llvm/test/BugPoint
  Testing Time: 1.24s
    Expected Passes    : 10

Guess I should have known that: https://github.com/ClangBuiltLinux/tc-build/commit/f0a88523bcfd60f649536a07f678e85ef31b4a2d. Thanks @nathanchance !

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62218/new/

https://reviews.llvm.org/D62218