[PATCH] D62220: [X86] Don't compare i128 through vector if construction not cheap (PR41971)

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added reviewers: spatel, RKSimon, craig.topper.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

Fix for https://bugs.llvm.org/show_bug.cgi?id=41971. Make the combineVectorSizedSetCCEquality() transform more conservative by checking that the bitcast to the vector type will be cheap/free for both operands. I'm considering it cheap if it's a constant, a load or already a vector. I've dropped the explicit check for `f128` because it should fall out naturally (in the cases where it'd be detrimental).


Repository:
  rL LLVM

https://reviews.llvm.org/D62220

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/test/CodeGen/X86/setcc-wide-types.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62220.200590.patch
Type: text/x-patch
Size: 37820 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190521/e93747e3/attachment.bin>