[PATCH] D62218: [docs][cmake] document LLVM_ENABLE_PLUGINS

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 21 14:22:00 PDT 2019


srhines added inline comments.


================
Comment at: llvm/docs/CMake.rst:602
+**LLVM_ENABLE_PLUGINS**::BOOL
+  If enabled, allows llvm to load plugins, such as LLVMgold or custom Clang
+  plugins. Default value is platform specific.
----------------
nickdesaulniers wrote:
> srhines wrote:
> > LLVM
> It was intentional; I think usually people try to load plugins through clang a la https://clang.llvm.org/docs/ClangPlugins.html.
> 
> I can change it to LLVM if you feel strongly about this. WDYT?
> 
> Also, should I maybe mention LLVM_ENABLE_PLUGINS on that page (and the LLVMGold one)?
Sorry, I forget that phabricator doesn't do intra-line highlights, and thus my message was misinterpreted. I wanted a fix for the capitalization of LLVM, since it isn't lowercase in this doc.

As far as the ClangPlugins.html page, I think that is generally user docs, so shouldn't be concerned with building your own LLVM distribution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62218/new/

https://reviews.llvm.org/D62218





More information about the llvm-commits mailing list