[PATCH] D62118: [DWARF] hoist nullptr checks. NFC
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 12:20:27 PDT 2019
probinson added a comment.
In D62118#1510389 <https://reviews.llvm.org/D62118#1510389>, @dblaikie wrote:
> Is there a test case for this codepath? Or should it be an assertion instead?
I think we should keep the check as is, it could be tickled by incorrect use of the API but a unittest should be able to exercise it fairly easily.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62118/new/
https://reviews.llvm.org/D62118
More information about the llvm-commits
mailing list