[PATCH] D62120: [ORC] fix unreachable code bug

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

We don't want to clear unconditionally: we should (at least optionally) preserve the state so that clients can attempt recovery from transient errors (e.g. network drop-outs).

That said, I think the behavior you have proposed is reasonable. We could make it the default by adding an argument to the run method:

  Error run(bool ClearCtorDtorsOnFailure = true);

Or we should add a clear() method to the CtorDtorRunner interface and document that clients need to clear the list manually on failure. I think the first option is probably less error-prone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62120/new/

https://reviews.llvm.org/D62120