[llvm] r361276 - [Dsymutil] Remove redundant argument (NFC)
Jonas Devlieghere via llvm-commits
llvm-commits at lists.llvm.org
Tue May 21 10:31:51 PDT 2019
Author: jdevlieghere
Date: Tue May 21 10:31:51 2019
New Revision: 361276
URL: http://llvm.org/viewvc/llvm-project?rev=361276&view=rev
Log:
[Dsymutil] Remove redundant argument (NFC)
The dwarf streamer already holds a copy of the link options, so there's
no need to pass them as an argument.
Modified:
llvm/trunk/tools/dsymutil/DwarfLinker.cpp
llvm/trunk/tools/dsymutil/DwarfStreamer.cpp
llvm/trunk/tools/dsymutil/DwarfStreamer.h
Modified: llvm/trunk/tools/dsymutil/DwarfLinker.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/DwarfLinker.cpp?rev=361276&r1=361275&r2=361276&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/DwarfLinker.cpp (original)
+++ llvm/trunk/tools/dsymutil/DwarfLinker.cpp Tue May 21 10:31:51 2019
@@ -626,7 +626,7 @@ unsigned DwarfLinker::shouldKeepVariable
MyInfo.InDebugMap = true;
return Flags | TF_Keep;
}
-
+
Optional<uint32_t> LocationIdx =
Abbrev->findAttributeIndex(dwarf::DW_AT_location);
if (!LocationIdx)
@@ -1820,7 +1820,7 @@ void DwarfLinker::patchLineTableForUnit(
OrigDwarf.getDWARFObj(), OrigDwarf.getDWARFObj().getLineSection(),
OrigDwarf.isLittleEndian(), Unit.getOrigUnit().getAddressByteSize());
if (Options.Translator)
- return Streamer->translateLineTable(LineExtractor, StmtOffset, Options);
+ return Streamer->translateLineTable(LineExtractor, StmtOffset);
Error Err = LineTable.parse(LineExtractor, &StmtOffset, OrigDwarf,
&Unit.getOrigUnit(), DWARFContext::dumpWarning);
@@ -2845,7 +2845,7 @@ bool DwarfLinker::link(const DebugMap &M
copySwiftInterfaces(ParseableSwiftInterfaces, ArchName, Options))
return error(toString(std::move(E)));
}
-
+
return Streamer->finish(Map, Options.Translator);
} // namespace dsymutil
Modified: llvm/trunk/tools/dsymutil/DwarfStreamer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/DwarfStreamer.cpp?rev=361276&r1=361275&r2=361276&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/DwarfStreamer.cpp (original)
+++ llvm/trunk/tools/dsymutil/DwarfStreamer.cpp Tue May 21 10:31:51 2019
@@ -584,8 +584,7 @@ void DwarfStreamer::emitLineTableForUnit
/// Copy the debug_line over to the updated binary while unobfuscating the file
/// names and directories.
-void DwarfStreamer::translateLineTable(DataExtractor Data, uint32_t Offset,
- LinkOptions &Options) {
+void DwarfStreamer::translateLineTable(DataExtractor Data, uint32_t Offset) {
MS->SwitchSection(MC->getObjectFileInfo()->getDwarfLineSection());
StringRef Contents = Data.getData();
Modified: llvm/trunk/tools/dsymutil/DwarfStreamer.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/DwarfStreamer.h?rev=361276&r1=361275&r2=361276&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/DwarfStreamer.h (original)
+++ llvm/trunk/tools/dsymutil/DwarfStreamer.h Tue May 21 10:31:51 2019
@@ -107,8 +107,7 @@ public:
/// Copy the debug_line over to the updated binary while unobfuscating the
/// file names and directories.
- void translateLineTable(DataExtractor LineData, uint32_t Offset,
- LinkOptions &Options);
+ void translateLineTable(DataExtractor LineData, uint32_t Offset);
/// Copy over the debug sections that are not modified when updating.
void copyInvariantDebugSection(const object::ObjectFile &Obj);
More information about the llvm-commits
mailing list