[PATCH] D61917: [IR] allow fast-math-flags on select of FP values

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

> To make that complete, I think we'd eventually allow adding FMF as an attribute to FP function arguments.

Okay. So the flag will always be a property of the value, and so we'll add them to loads and function arguments, etc. This makes sense to me, and seems like it creates an unambiguous picture. We need to be a bit careful how we define this -- I think that we want a disallowed value in one of these arguments, etc. to be poison and not UB. We'll need to be more aggressive about propagating the flags when we inline the functions when they have the flags on their return values (because we don't otherwise have a way to get the information when the values are later used as inputs).

LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61917/new/

https://reviews.llvm.org/D61917