[PATCH] D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux

[Julian Lettner via Phabricator via llvm-commits]

yln added a comment.

In D61708#1509531 <https://reviews.llvm.org/D61708#1509531>, @dvyukov wrote:

> I am still a bit worried by the amount of complex code we have for this. I wonder if there is a simpler way to do this. Have you considered any other alternatives?


I agree with you on the complexity here. Alternatives: it's the only thing I was able to come up with without the help of the compiler.

> Could we emit some symbol in the library and then use dlsym on it? Or maybe emit some section and then iterate over section names only?

That sounds certainly possible (and less complex). Initially, I wasn't sure if we want to try to avoid requiring compiler, but I can't think of disadvantages that we don't already have (compiler/runtime compatibility).

I will try the emit symbol/dlopen approach you suggested and open a new revision for it. Is it okay if this is TSan-specific?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61708/new/

https://reviews.llvm.org/D61708